This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix webpack regex embed comment termination#262
Merged
mxstbr merged 1 commit intocarteb:masterfrom Jun 2, 2016
Merged
Conversation
Webpack has no protection against inserting */ in the comments it writes when output.pathinfo is true
wmertens
added a commit
to wmertens/webpack
that referenced
this pull request
Jun 7, 2016
Using `/*` as comment delimiters allows request names to terminate a comment early, like in carteb/carte-blanche#262.
cletusw
pushed a commit
to cletusw/webpack
that referenced
this pull request
Aug 25, 2016
Using `/*` as comment delimiters allows request names to terminate a comment early, like in carteb/carte-blanche#262.
11 tasks
cletusw
pushed a commit
to cletusw/webpack
that referenced
this pull request
Sep 8, 2016
Using `/*` as comment delimiters allows request names to terminate a comment early, like in carteb/carte-blanche#262.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack has no protection against inserting */ in the comments it writes when output.pathinfo is true