Repository navigation
Guidelines pre-PEP: Subset of C, some Types, Return values, Output arguments - #53
Merged
Merged
Conversation
zooba
approved these changes
Nov 12, 2024
zooba
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I don't think anything is controversial here.
mdboom
approved these changes
Nov 12, 2024
vstinner
reviewed
Nov 13, 2024
encukou
commented
Nov 13, 2024
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Steve Dower <steve.dower@microsoft.com>
erlend-aasland
approved these changes
Nov 13, 2024
Contributor
Author
|
Serhiy, are you OK with this version? (I'll treat earlier reviews as valid: The changes were minor, and everyone will get plenty of time to re-review when the document is complete.) |
This was referenced Nov 29, 2024
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a while since I last proposed some guidelines. Here's the next chunk.
@zooba @vstinner @erlend-aasland @serhiy-storchaka @mdboom, please add your comments or approvals.
Like last time, if a section is controversial I can delete it for now, and split it out into a separate discussion.
Smaller issues that need substantial extra work/discussion can go in the checklist at #44.