Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autocurrently reports a recursive dependency when a task named__proto__has a dependency, even for a valid acyclic graph. A task with that name can also lose its own property in successful and partial-error results.autoInjectdrops the same task name while constructing the task map passed toauto.For example, this graph is rejected before either task runs:
The dependency counts and
autoInjecttask map now use null-prototype objects, and__proto__results are stored as own data properties. The public results object keeps its usual prototype and property attributes, including when a task fails.Twelve regression tests cover independent task values, a dependent task and downstream consumer, partial-error results, the Promise API, and explicit or inferred dependency injection. All 715 Node tests and ESLint pass. A separate agent also checked ordinary and null-prototype task maps, real cycles, and cancellation.
Prepared by a Codex agent and independently reviewed by another agent.