Skip to content

fix: reject expiration timestamp 0 and accept far-future timestamps in getEventExpiration() #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Priyanshubhartistm wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

fix: reject expiration timestamp 0 and accept far-future timestamps in getEventExpiration() #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-event-expiration-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"nostream": patch
---

fix: reject expiration timestamp 0 and accept safe-integer timestamps beyond year 2287 in getEventExpiration()
2 changes: 1 addition & 1 deletion src/utils/event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export const getEventExpiration = (event: Event): number | undefined => {

const expirationTime = Number(rawExpirationTime)

if (Number.isSafeInteger(expirationTime) && Math.log10(expirationTime) < 10) {
if (Number.isSafeInteger(expirationTime) && expirationTime > 0) {
return expirationTime
}
}
Expand Down
10 changes: 10 additions & 0 deletions test/unit/utils/event.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,16 @@ describe('NIP-40', () => {
event.tags = [['expiration', 'a']]
expect(getEventExpiration(event)).to.be.undefined
})

it('returns false if expiration is 0', () => {
event.tags = [['expiration', '0']]
expect(getEventExpiration(event)).to.be.undefined
})

it('returns true if expiration is a safe integer beyond year 2287', () => {
event.tags = [['expiration', '10000000000']]
expect(getEventExpiration(event)).to.equal(10000000000)
})
})

describe('isExpiredEvent', () => {
Expand Down
Loading