Change postgresql to use concat() instead of || - #19584
Open
othercorey wants to merge 1 commit into
Open
Conversation
othercorey
force-pushed
the
postgres-concat
branch
from
August 5, 2026 03:00
71f0fd8 to
210249f
Compare
othercorey
force-pushed
the
postgres-concat
branch
from
August 5, 2026 03:10
210249f to
dc28882
Compare
Contributor
Author
|
@markstory Because only the bound parameters are cast, we could use the postgres shorthand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this change probably belongs in 6.0.
PostgreSQL added
concat()in 9.1 with proper support for NULL arguments - they are ignored instead of returning NULLIn postgrs, bound parameters have to be cast to
textto satisfy the variadic arguments since it requires types be known at compile time to support argument overloading.The concat() function should be what we want and only be safer, but since it would change the return type for NULL arguments, it's not technically backwards compatible.