chore: Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests - #19550
Open
samsonasik wants to merge 3 commits into
Open
chore: Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests#19550samsonasik wants to merge 3 commits into
samsonasik wants to merge 3 commits into
Conversation
dereuromark
reviewed
Jul 20, 2026
Co-authored-by: Mark Scherer <dereuromark@users.noreply.github.com>
Contributor
Author
|
@dereuromark ready 👍 |
dereuromark
approved these changes
Jul 20, 2026
dereuromark
left a comment
Member
There was a problem hiding this comment.
Even though probably a bit overkill I guess this seems fine to apply.
Member
|
This is unnecessary code churn and a pointless rule given that we actually have test cases extending other test cases. |
Member
I didnt see any fails here. |
Contributor
Author
|
The rule is properly verify if the class has child, that class is skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StructArmed 0.15.0 introduce
ExtendedClassAwareRuleInterfacethat makes itsMustBeFinalRulesafely be used to skip if there is class that extend target class.This PR bump StructArmed to
^0.15and apply theMustBeFinalRulewith single command to fix.to finalize tests classes.