Skip to content

Replace LoadLibrary by LoadLibraryW - #25

Closed
zcbenz wants to merge 1 commit into
c-ares:masterfrom
zcbenz:unicode-loadlibrary
Closed

zcbenz wants to merge 1 commit into
c-ares:masterfrom
zcbenz:unicode-loadlibrary

Conversation

@zcbenz

@zcbenz zcbenz commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

On Windows, when compiling with UNICODE defined, LoadLibrary becomes LoadLibraryW. When an ASCII string is passed to that function it crashes.

See nodejs/node#226 for more discussions on this.

On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.
@nicolasnoble

Copy link
Copy Markdown
Contributor

Fun, I made the exact same pull request a while ago: #17

@zcbenz

zcbenz commented Mar 21, 2015

Copy link
Copy Markdown
Contributor Author

@nicolasnoble lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants