Add configurability for path to resolv.conf file (#220)#221
Add configurability for path to resolv.conf file (#220)#221bradh352 merged 3 commits intoc-ares:masterfrom
Conversation
| } | ||
| } | ||
| fclose(fp); | ||
| } |
There was a problem hiding this comment.
Too much duplication here of logic. If someone explicitly configured a resolveconf_path, I don't see any reason to use the default PATH_RESOLV_CONF. So really we should just do this once. I'd think it makes more sense to error out anyhow.
|
regarding windows support, this would be non-windows only ... simply putting it in the docs is sufficient. |
|
looks good to me, if you just add the minor doc tweak I think it should be good to merge. |
|
Great, will do that. Also, anything to be done towards the Travis build failures? I'm facing the following: |
|
looks like travis succeeded to me. Where did you see this? |
|
Ah, my bad. This was against my fork, in my travis account. |
|
Hi @bradh352 , just pushed some documentation to the man pages, please review. |
|
Thanks |
struct ares_optionsandstruct ares_channeldata, and similarlyares_init_options(),ares_save_options(), andinit_by_resolv_conf()CONTAINED_TEST_F(could not test locally, as local machine is darwin, which does not support linux LXC)--enable-maintainer-modeand--enable-debugFixes #220