Skip to content

fix(plan): show plan link and rollout guidance after approval#19922

Merged
boojack merged 4 commits intomainfrom
steven/plan-link
Apr 9, 2026
Merged

fix(plan): show plan link and rollout guidance after approval#19922
boojack merged 4 commits intomainfrom
steven/plan-link

Conversation

@boojack
Copy link
Copy Markdown
Member

@boojack boojack commented Apr 9, 2026

Summary

  • Show the Plan link for database change issues once approval is complete, even before a rollout exists
  • Add clearer rollout guidance in the deploy phase and issue sidebar for manual follow-up cases
  • Refine rollout messaging for users without the Create Rollout permission

Key Changes

  • Rename the rollout-ready link to a Plan link and update its visibility logic to cover approved or skipped issues without a rollout
  • Add a checks warning hint in the issue review sidebar when approval is done but rollout has not been created because checks failed
  • Rework the deploy future state into a more compact checklist layout and downgrade the manual rollout action to a secondary button
  • Hide the manual rollout button for users without bb.rollouts.create while keeping a permission-based explanation visible
  • Update localized copy across supported languages to match the new Plan link and rollout guidance behavior

Motivation

  • Users were left without a clear next step when approval finished but rollout had not been created automatically
  • The deploy UI needed lighter, more explicit guidance about rollout readiness, manual actions, and permission limits

Testing

  • pnpm --dir frontend fix
  • pnpm --dir frontend check
  • pnpm --dir frontend type-check
  • pnpm --dir frontend test

@boojack boojack requested a review from a team as a code owner April 9, 2026 04:18
@cla-bot cla-bot bot added the cla-signed label Apr 9, 2026
@boojack boojack requested a review from zchpeter April 9, 2026 04:18
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91c0182cb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/src/components/Plan/logic/usePlanLink.ts Outdated
Comment thread frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9c05de0f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
8 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b223dba43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@boojack boojack merged commit 1c079fd into main Apr 9, 2026
14 of 16 checks passed
@boojack boojack deleted the steven/plan-link branch April 9, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants