Fix Example extension for Perl 5.30#108
Open
gdsotirov wants to merge 2 commits into
Open
Conversation
With Perl 5.30 and later there is a warning that variable length lookbehind is experimental: Variable length lookbehind is experimental in regex; marked by <-- HERE in m/(?<=<td id="error_msg" clas[s]="throw_error">).*(?=</td>) <-- HERE / at ./extensions/Example/Extension.pm line 499. So modify regular expression to use \K - the special form of positive lookbehind that "effectively provides non-experimental variable-length lookbehind of any length". Also match text between tags using non-greedy ? modifier as otherwise everything until the final closing div is replaced and thus error page appears broken. See https://perldoc.perl.org/perlre#Lookaround-Assertions
justdave
pushed a commit
to justdave/bugzilla
that referenced
this pull request
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Perl 5.30 and later there is a warning that variable length lookbehind is experimental when Example extension is enabled:
So modify regular expression to use
\K- the special form of positive lookbehind that "effectively provides non-experimental variable-length lookbehind of any length". See Lookaround Assertions.Also match text between tags using non-greedy
?modifier as otherwise everything until the final closing div is replaced and thus error page appears broken.Also change tag in regular expression from
tdtodivas the templates were modified a long time ago.