Sign In Screen#2
Open
buddhdev-jay wants to merge 1 commit into
Open
Conversation
bd4d680 to
a21f399
Compare
purvesh-d
requested changes
May 19, 2022
| const val THIRTYEIGHT = 38 | ||
| const val TWENETYFOUR = 24 | ||
| const val ONE = 1 | ||
| const val ZERO = 0 |
| app:layout_constraintTop_toTopOf="parent" /> | ||
|
|
||
| <androidx.appcompat.widget.AppCompatTextView | ||
| android:id="@+id/textview_signIn_tagline" |
| app:layout_constraintTop_toBottomOf="@id/textview_signIn_tagline" /> | ||
|
|
||
| <androidx.appcompat.widget.AppCompatEditText | ||
| android:id="@+id/edi_txt_signIn_email" |
| android:textSize="@dimen/_10ssp" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/txt_layout_password" /> | ||
|
|
| app:layout_constraintTop_toBottomOf="@id/btn_signIn" /> | ||
|
|
||
| <androidx.appcompat.widget.AppCompatTextView | ||
| android:id="@+id/textview_Or" |
a0be382 to
9b0f713
Compare
purvesh-d
requested changes
May 23, 2022
|
|
||
| override fun updateDrawState(drawState: TextPaint) { | ||
| super.updateDrawState(drawState) | ||
| drawState.isUnderlineText = false |
| android:imeOptions="actionNext" | ||
| android:inputType="textEmailAddress" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/textview_signIn_email_header" /> |
Collaborator
There was a problem hiding this comment.
naming convention textview_signIn_email_header
| app:passwordToggleEnabled="true"> | ||
|
|
||
| <androidx.appcompat.widget.AppCompatEditText | ||
| android:id="@+id/editxt_signIn_password" |
614fda1 to
b6d4db7
Compare
purvesh-d
requested changes
May 24, 2022
|
|
||
| class OnboardingViewHolder(binding:SplashScreenItemContainerLayoutBinding) : RecyclerView.ViewHolder(binding.root) { | ||
| //Will be Implemented Later | ||
| //Will be Implemeted Later |
fa90e61 to
a89853f
Compare
purvesh-d
requested changes
May 26, 2022
| android:layout_marginStart="@dimen/_24sdp" | ||
| android:layout_marginTop="@dimen/_22sdp" | ||
| android:fontFamily="@font/manropemedium" | ||
| android:text="or" |
| @@ -0,0 +1,35 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
| <style name="edit_textStyle" parent="ThemeOverlay.AppCompat" > | |||
Collaborator
There was a problem hiding this comment.
give style name in camelCase only
| <item name="android:layout_marginEnd">@dimen/_24sdp</item> | ||
| <item name="android:background">@drawable/edit_text_border</item> | ||
| </style> | ||
| <style name="social_media_button" parent="ThemeOverlay.AppCompat"> |
Collaborator
There was a problem hiding this comment.
same here, check in all the style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.