Skip to content

github actions #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashdsaraf merged 4 commits into from
Apr 15, 2026
+26 −7
Merged

github actions #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6700e7
fix github actions workflow
shivamku-BS Apr 7, 2026
099a514
fix: use global.json
shivamku-BS Apr 8, 2026
a03cf42
fix: requierd version for global.json
shivamku-BS Apr 8, 2026
cff99e9
added global.json for version match
shivamku-BS Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions .github/workflows/reviewing_changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,19 @@ jobs:
strategy:
fail-fast: false
max-parallel: 3
# .net5 runner doesn't installed at runtime, so skipping it and adding other .net latest versions.
# added target-framework in matrix to avoid runtime errors as each runner has only its matching runtime installed.
matrix:
dotnet: ['6.0.x', '5.0.x']
dotnet: ['6.0.x', '8.0.x', '9.0.x', '10.0.x']
include:
- dotnet: '6.0.x'
target-framework: 'net6.0'
- dotnet: '8.0.x'
target-framework: 'net8.0'
- dotnet: '9.0.x'
target-framework: 'net9.0'
- dotnet: '10.0.x'
target-framework: 'net10.0'
os: [ windows-latest ]
name: NUnit Repo ${{ matrix.dotnet }} - ${{ matrix.os }} Sample
env:
Expand Down Expand Up @@ -48,21 +59,29 @@ jobs:
console.log('Failed to create check run')
}
- name: Setup dotnet
id: setup-dotnet
uses: actions/setup-dotnet@v3
with:
dotnet-version: ${{ matrix.dotnet }}

- name: Pin SDK version via global.json
run: |
$major = "${{ matrix.target-framework }}".Replace("net","").Split(".")[0]
$version = "$major.0.100"
"{`"sdk`":{`"version`":`"$version`",`"rollForward`":`"latestFeature`"}}" | Set-Content global.json
Get-Content global.json
shell: pwsh

- name: Install dependencies
run: |
run: |
dotnet --version
Comment thread
shivam5643 marked this conversation as resolved.
dotnet build

dotnet build /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }}

- name: Run sample tests
run: dotnet test --filter "Category=sample-test"
run: dotnet test --filter "Category=sample-test" /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }}

- name: Run local tests
run: dotnet test --filter "Category=sample-local-test"
run: dotnet test --filter "Category=sample-local-test" /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }}

- if: always()
uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975
Expand Down
2 changes: 1 addition & 1 deletion NUnit-BrowserStack/NUnit-BrowserStack.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0</TargetFrameworks>
<RootNamespace>SingleTest</RootNamespace>
<AssemblyName>SingleTest</AssemblyName>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down