Conversation
a99c509 to
61ebf7e
Compare
|
rs@3 is significantly different in the browser and in node so we probably need some browserified tests here. it also drops support for some browser versions but i think its support is now the same as Buffer's so that's ok. |
|
Anyone reviewing this? readable-stream v3 is now 3.0.6 btw. |
|
there are still some problems with this unfortunately. i had some runtime crashes involving |
|
@goto-bus-stop I believe there have been some changes with the use of |
|
@arahmanan it looks like it! that means this should almost be ready. i requested a saucelabs.com account for browserify so we can add some browser tests, i would like to be a bit more certain about what we support. especially because readable-stream now has slight implementation differences in the browser version and the node.js version for compatibility reasons. once that's set up, this can finally be released :) |
|
status update: saucelabs approved the request quickly, but I ran into some trouble claiming it. I only just finally emailed them about it, hopefully it can be resolved soon! |
|
@goto-bus-stop would you consider forking and publishing this update yourself? I'm currently looking into updating these builtins in jspm (https://github.com/jspm/jspm-core) and this would be great to avoid the duplication that now comes into effect since |
|
Saucelabs says yes! 📦 |
|
Amazing, persistence pays off :) |
Closes #17
Closes #22
Closes #24