Repository navigation
Adding basedir to fix node resolver - #154
Merged
Merged
Conversation
Member
|
This seems like a good idea. Could you add a test? |
Contributor
Author
|
Thanks for the quick reply. Added some tests, please advise if you had something else in mind. |
Contributor
Author
|
@goto-bus-stop thoughts? |
Member
|
📦 6.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in case you use node-resolve instead of the default browser-resolve the visitor fails as it can't find the required relative file from the currently visited, as the basedir is not set.