Skip to content

ci: add concurrency group to eval-on-pr workflow#4625

Open
mendral-agent wants to merge 1 commit intobrowser-use:mainfrom
mendral-agent:mendral/add-concurrency-eval-on-pr
Open

ci: add concurrency group to eval-on-pr workflow#4625
mendral-agent wants to merge 1 commit intobrowser-use:mainfrom
mendral-agent:mendral/add-concurrency-eval-on-pr

Conversation

@mendral-agent
Copy link
Copy Markdown

@mendral-agent mendral-agent commented Apr 6, 2026

Summary

  • Adds a concurrency block to eval-on-pr.yml so that redundant evaluation runs are cancelled when new commits are pushed to the same PR.

Problem

eval-on-pr.yml triggers on every synchronize event (new push to a PR) but has no concurrency group. If a contributor pushes multiple commits in quick succession, each push triggers a separate evaluation API call to the external platform, and none of the previous runs get cancelled.

Every other CI workflow in this repo (test.yaml, lint.yml, docker.yml, publish.yml) already uses a concurrency group with cancel-in-progress: true. This workflow was missing it.

Fix

Added a concurrency block using the same pattern as other workflows:

concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
  cancel-in-progress: true

This groups runs by PR number and cancels in-progress runs when a new one starts, preventing redundant evaluation API calls.

Verification

  • Push two commits quickly to a PR — the first evaluation run should be cancelled.
  • The concurrency group key format matches all other workflows in the repo.

Note

Created by Mendral. Tag @mendral-agent with feedback or questions.


Summary by cubic

Add a concurrency group to eval-on-pr.yml so evaluation runs for the same PR cancel when new commits are pushed, avoiding redundant external API calls. Matches other workflows by grouping on PR number and setting cancel-in-progress: true.

Written for commit 98ac1e5. Summary will update on new commits.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 6, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Apr 21, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 3f9520c examples/glazyr_benchmark.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants