Fix Table.hasColumn for columns with custom property names#322
Merged
Conversation
There was a bug which caused Table.hasColumn to return false when passed a property name (defined via column.property) instead of a column name.
Owner
|
Thanks a lot for your work on this! Sorry it took me a while to get to it - life got in the way & I got really busy tending to some things. I'll merge this now & push a new minor version to npm here in just a few minutes. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug which caused Table.hasColumn to return false when passed a property name (defined via column.property) instead of a column name.
This now works and all tests pass: