Fix sqlite date functions for epoch#319
Merged
Merged
Conversation
Owner
|
Hey thanks for the PR! Would it be possible to add tests for your behavior while also keeping the old tests for the existing behavior intact? Maybe another test file where you apply the config to use epoch timestamps & then check the new output? If I'm reading this right it looks like this just changes the old tests, which in turn removes test coverage for the old behavior. |
Contributor
Author
|
Half the tests use epoch (month and hour) the other use ISO (year and day). I can certainly add 4 more tests. Just let me know! |
Owner
|
Ah sorry didn't know half the tests still used the old epoc time! I just looked @ the diff & ran the tests. If both cases are covered we're good to go! I'll release a new minor version to npm in just a few min here! 💃 thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via configuration you can set SQLite to use epoch timestamps or ISO formatted dates. The original implementation only worked for ISO formatted dates. This PR fixes that.