INSERT INTO ... SELECT create with .add()#301
Merged
Conversation
…ated using the .add() function.
Owner
|
This is great! I'll get this merged & fix the jslint error too. 😄 |
brianc
added a commit
that referenced
this pull request
Feb 25, 2016
INSERT INTO ... SELECT create with .add()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this pull request, this code
would generate (properly quoted)
Notice the parentheses around the
SELECTclause. In many cases, this isn't a problem, but in Microsoft SQL server, when you try to add anORDER BYclause onto your select, it is a syntax error when there are parentheses around theSELECTstatement.This pull request makes the above query generate:
which is exactly what is generated when you write the query like:
So it actually generates more consistent SQL regardless of the way that the query was constructed.