Fix booleans and objects#291
Merged
Merged
Conversation
Owner
|
@barryhammen I'm sorry it took me a while to get to this PR - got kinda behind on things at work for a while. This is fantastic. I'm gonna merge it & push a new version today! 💃 thank you sooo much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sqlite doesn't support TRUE and FALSE as boolean values, only 1 and 0.
Also, if trying to update using a JSON object, if the object didn't have an explicit .toString() method, it would end up trying to save '[object Object]' to the database. Switched out to use JSON.stringify in that case.