Fixed PostgreSQL array insertion syntax.#290
Merged
Merged
Conversation
Contributor
Author
|
@brianc have you had a chance to look through this change? Would love some feedback. |
Owner
|
Hey I think this looks pretty good! Sorry it too me so long to get to it. I'll merge this & and get a new version pushed out! 💃 |
brianc
added a commit
that referenced
this pull request
Jan 27, 2016
Fixed PostgreSQL array insertion syntax.
brianc
added a commit
that referenced
this pull request
Jan 27, 2016
Revert "Merge pull request #290 from ericjperry/master"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres supports arrays natively, but they were not being created properly with the handling of arrays in the Postgres dialect. According to the current documentation arrays are wrapped as a string (single quoted), with brackets, and each string (if the elements are strings) is double quoted. This PR updates the handling of arrays (for Postgres only) to match what the db expects.