Skip to content

Added varchar[] and char[] to array parsing.#248

Merged
brianc merged 2 commits into
brianc:masterfrom
liamks:master
Jan 24, 2013
Merged

Added varchar[] and char[] to array parsing.#248
brianc merged 2 commits into
brianc:masterfrom
liamks:master

Conversation

@liamks
Copy link
Copy Markdown
Contributor

@liamks liamks commented Jan 18, 2013

It turns out I didn't have to modify your existing parse function at all - all I had to do was register the above datatypes =)

I haven't added any tests yet but I was thinking of doing the following for a test:

setup:

  1. create a database
  2. create a table with columns (text[], varchar[], char[])

test:

  1. insert data into above table
  2. select data from above table and see if it matches expectations

teardown:

  1. remove table
  2. remove databse

Considering the above is at least 100 lines of code I want to make sure that there wasn't an easier way of testing the above.

@brianc
Copy link
Copy Markdown
Owner

brianc commented Jan 21, 2013

@liamks
Copy link
Copy Markdown
Contributor Author

liamks commented Jan 24, 2013

Thanks for the pointer @brianc. I've added 3 unit tests, and I've run all the tests on my machine and everything passes.

@brianc
Copy link
Copy Markdown
Owner

brianc commented Jan 24, 2013

perfectamundo! 🌟 🍰

brianc added a commit that referenced this pull request Jan 24, 2013
Added varchar[] and char[] to array parsing.
@brianc brianc merged commit beb3e4f into brianc:master Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants