Skip to content

Commit a32f71c

Browse files
jmdobryjmdobry
authored
* Refactored Pub/Sub samples into nice command-line programs, like the new Cloud Storage samples (GoogleCloudPlatform#164)
* Brought Pub/Sub samples code coverage up to 98.66%
1 parent 5afb195 commit a32f71c

36 files changed

+1603
-884
lines changed

‎bigquery/system-test/dataset_size.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('bigquery:dataset_size', function () {
2121
'bigquery-public-data',
2222
'hacker_news',
2323
function (err, size) {
24-
assert(!err);
24+
assert.ifError(err);
2525
assert.equal(typeof size, 'string');
2626
assert(size.indexOf(' GB') === size.length - 3);
2727
done();

‎bigquery/system-test/getting_started.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('bigquery:getting_started', function () {
1919
it('should run a query', function (done) {
2020
gettingStartedExample.main(
2121
function (err, rows) {
22-
assert(!err);
22+
assert.ifError(err);
2323
assert(Array.isArray(rows));
2424
assert.equal(rows.length, 10);
2525
done();

‎bigquery/system-test/load_data_from_csv.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('bigquery:load_data_from_csv', function () {
3939
done(err);
4040
});
4141
} else {
42-
assert(!err);
42+
assert.ifError(err);
4343
// metadata
4444
assert.equal(results[1].status.state, 'DONE');
4545
done();

‎bigquery/system-test/load_data_from_gcs.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe('bigquery:load_data_from_gcs', function () {
4040
done(err);
4141
});
4242
} else {
43-
assert(!err);
43+
assert.ifError(err);
4444
// metadata
4545
assert.equal(results[1].status.state, 'DONE');
4646
done();

‎computeengine/system-test/vms.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var vmsExample = require('../vms');
1818
describe('computeengine:vms', function () {
1919
it('should retrieve vms', function (done) {
2020
vmsExample.main(function (err, result) {
21-
assert(!err);
21+
assert.ifError(err);
2222
assert(result);
2323
assert(Array.isArray(result));
2424
done();

‎computeengine/system-test/vms_api.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var vmsExample = require('../vms_api');
1818
describe('computeengine:vms_api', function () {
1919
it('should retrieve vms', function (done) {
2020
vmsExample.main(function (err, result) {
21-
assert(!err);
21+
assert.ifError(err);
2222
assert(result);
2323
done();
2424
});

‎datastore/system-test/concepts.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe('datastore:concepts', function () {
131131
it('performs a projection query', function (done) {
132132
entity.testProperties(function (err, tasks) {
133133
console.log(err, tasks);
134-
assert(!err);
134+
assert.ifError(err);
135135
setTimeout(function () {
136136
query.testRunQueryProjection(done);
137137
}, 1000);
@@ -203,7 +203,7 @@ describe('datastore:concepts', function () {
203203

204204
it.skip('allows manual pagination through results', function (done) {
205205
entity.testBatchUpsert(function (err) {
206-
assert(!err);
206+
assert.ifError(err);
207207
setTimeout(function () {
208208
query.testCursorPaging(done);
209209
}, 1000);

‎datastore/system-test/tasks.test.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('datastore:tasks', function () {
3232

3333
it('should mark a task as done', function (done) {
3434
getTaskId(function (err, taskId) {
35-
assert(!err);
35+
assert.ifError(err);
3636
tasks.updateEntity(taskId, done);
3737
});
3838
});
@@ -43,14 +43,14 @@ describe('datastore:tasks', function () {
4343

4444
it('should delete a task', function (done) {
4545
getTaskId(function (err, taskId) {
46-
assert(!err);
46+
assert.ifError(err);
4747
tasks.deleteEntity(taskId, done);
4848
});
4949
});
5050

5151
it('should format tasks', function (done) {
5252
tasks.retrieveEntities(function (err, _tasks) {
53-
assert(!err);
53+
assert.ifError(err);
5454
assert.doesNotThrow(function () {
5555
tasks.formatTasks(_tasks);
5656
});

‎language/system-test/analyze.test.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('language:analyze', function () {
2121
'sentiment',
2222
'This gazinga pin is bad and it should feel bad',
2323
function (err, result) {
24-
assert(!err);
24+
assert.ifError(err);
2525
assert(result);
2626
assert(result.documentSentiment);
2727
assert(result.documentSentiment.polarity < 0);
@@ -34,7 +34,7 @@ describe('language:analyze', function () {
3434
'entities',
3535
'Mark Twain is the author of a book called Tom Sawyer',
3636
function (err, result) {
37-
assert(!err);
37+
assert.ifError(err);
3838
assert(result);
3939
assert(result.entities && result.entities.length);
4040
assert(result.entities[0].name === 'Mark Twain');
@@ -51,7 +51,7 @@ describe('language:analyze', function () {
5151
'buy some better butter - better than this bitter butter - it will ' +
5252
'make my batter better."',
5353
function (err, result) {
54-
assert(!err);
54+
assert.ifError(err);
5555
assert(result);
5656
assert(result.sentences && result.sentences.length);
5757
assert(result.tokens && result.tokens.length > 5);

‎logging/system-test/export.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var exportExample = require('../export');
1818
describe('logging:export', function () {
1919
it('should list sinks', function (done) {
2020
exportExample.main(function (err, sinks) {
21-
assert(!err);
21+
assert.ifError(err);
2222
assert(sinks, 'should have received sinks');
2323
assert(Array.isArray(sinks), 'sinks should be an array');
2424
done();

0 commit comments

Comments
 (0)