Updated readWriteTransaction to fix bug (GoogleCloudPlatform#317)

ryanmats · Ace Nassri · commit 53c2d0a30e37 · 2017-02-23T16:23:34.000-06:00
* Updated readWriteTransaction to fix bug Documentation at https://cloud.google.com/spanner/docs/transactions#rw_transaction_example says that second budget should be at least $300,000 for the transaction to proceed. I'm fixing this for Python / Node. Addresses bug #35360945. * Moved 300000 to minimumAmountToTransfer constant as per code review
diff --git a/spanner/transaction.js b/spanner/transaction.js
@@ -100,6 +100,7 @@ function readWriteTransaction (instanceId, databaseId) {
   // at a specific point in time
   let transaction, firstBudget, secondBudget;
   const transferAmount = 200000;
+  const minimumAmountToTransfer = 300000;
 
   database.runTransaction()
     .then((results) => {
@@ -126,8 +127,8 @@ function readWriteTransaction (instanceId, databaseId) {
           console.log(`The second album's marketing budget: ${secondBudget}`);
 
           // Makes sure the second album's budget is sufficient
-          if (secondBudget < transferAmount) {
-            throw new Error(`The second album's budget (${secondBudget}) is less than the transfer amount (${transferAmount}).`);
+          if (secondBudget < minimumAmountToTransfer) {
+            throw new Error(`The second album's budget (${secondBudget}) is less than the minimum required amount to transfer.`);
           }
         }),
 
