Only use 'pragma once' when supported. - #6
Closed
danieljames wants to merge 1 commit into
Closed
Conversation
stefanseefeld
requested changes
Sep 29, 2016
stefanseefeld
left a comment
Member
There was a problem hiding this comment.
It isn't clear to me that we need these pragmas at all, given that the headers also use the usual header guards. Wouldn't it be simpler to just remove these 'pragma once' lines as redundant ?
Contributor
Author
|
Sure, if that's what you prefer. |
stefanseefeld
force-pushed
the
develop
branch
2 times, most recently
from
October 8, 2016 17:34
8ccdcff to
3ace4a0
Compare
Member
|
Close as obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checks were removed in 42e7d7b. This is a little better as most compilers support it nowadays.