Skip to content

Fix warning C4456: declaration of 'storage' hides previous local declaration #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Osyotr wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix warning C4456: declaration of 'storage' hides previous local declaration #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix warning C4456: declaration of 'storage' hides previous local decl… 
…aration

This is a copy-paste issue introduced in aca3c80
  • Loading branch information
@Osyotr
Osyotr authored Apr 22, 2025
commit 8a689238b835031419bc922aaeed2789673f7f70
13 changes: 3 additions & 10 deletions include/boost/python/converter/shared_ptr_from_python.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,9 @@ struct shared_ptr_from_python
new (storage) SP<T>();
else
{
void *const storage = ((converter::rvalue_from_python_storage<SP<T> >*)data)->storage.bytes;
// Deal with the "None" case.
if (data->convertible == source)
new (storage) SP<T>();
else
{
SP<void> hold_convertible_ref_count((void*)0, shared_ptr_deleter(handle<>(borrowed(source))) );
// use aliasing constructor
new (storage) SP<T>(hold_convertible_ref_count, static_cast<T*>(data->convertible));
}
SP<void> hold_convertible_ref_count((void*)0, shared_ptr_deleter(handle<>(borrowed(source))) );
// use aliasing constructor
new (storage) SP<T>(hold_convertible_ref_count, static_cast<T*>(data->convertible));
}
data->convertible = storage;
}
Expand Down