Skip to content

Prevent potential data loss in numpy's dtype::get_itemsize(). #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohannesWilde wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Prevent potential data loss in numpy's dtype::get_itemsize(). #463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c641a80
Prevent potential data loss in numpy's dtype::get_itemsize().
JohannesWilde Dec 14, 2024
4a0c096
Use boost::python::ssize_t instead of Py_ssize_t - it is available fo…
JohannesWilde Dec 14, 2024
af8a5f7
Exempt negative itemsize from contiguity and alginment.
JohannesWilde Dec 14, 2024
753b434
Add comments.
JohannesWilde Dec 14, 2024
25a1994
Add constness for unmodified internal parameters.
JohannesWilde Dec 14, 2024
1105d37
Change size type to boost::python::ssize_t - as did numpy with versio…
JohannesWilde Dec 14, 2024
6614188
Use the const-accessor methods when using const_iterators.
JohannesWilde Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use boost::python::ssize_t instead of Py_ssize_t - it is available fo… 
…r all PY_VERSION_HEX.
  • Loading branch information
@JohannesWilde
JohannesWilde committed Dec 14, 2024
commit 4a0c0962bcac64a94f005a07ffee9861983feefa
2 changes: 1 addition & 1 deletion include/boost/python/numpy/dtype.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class BOOST_NUMPY_DECL dtype : public object {
template <typename T> static dtype get_builtin();

/// @brief Return the size of the data type in bytes.
Py_ssize_t get_itemsize() const;
boost::python::ssize_t get_itemsize() const;

/**
* @brief Compare two dtypes for equivalence.
Expand Down
2 changes: 1 addition & 1 deletion src/numpy/dtype.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ python::detail::new_reference dtype::convert(object const & arg, bool align)
return python::detail::new_reference(reinterpret_cast<PyObject*>(obj));
}

Py_ssize_t dtype::get_itemsize() const {
boost::python::ssize_t dtype::get_itemsize() const {
#if NPY_ABI_VERSION < 0x02000000
return reinterpret_cast<PyArray_Descr*>(ptr())->elsize;
#else
Expand Down