Skip to content

feat: rework spinner to use Prompt api #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
43081j wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: rework spinner to use Prompt api #479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f95d408
wip: move spinner to use prompt API
43081j Jan 29, 2026
4d48890
Merge branch 'main' into good-spinner
43081j Feb 24, 2026
c6c2768
test: add core tests
43081j Feb 24, 2026
505e7ff
chore: fix rendering order
43081j Feb 24, 2026
3d2ca73
fix: add guide prefix
43081j Feb 25, 2026
b53162c
fix: remove extra newline
43081j Feb 25, 2026
6f4ae32
chore: update snaps and ci
43081j Mar 10, 2026
247c9dc
test: default exit code to 0
43081j Mar 12, 2026
780cb4c
chore: add changeset
43081j Mar 12, 2026
22a798b
Merge branch 'main' into good-spinner
43081j Apr 8, 2026
31baff5
Merge branch 'main' into good-spinner
43081j Apr 23, 2026
1594d6e
fix: ignore returns
43081j Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix rendering order
  • Loading branch information
@43081j
43081j committed Feb 24, 2026
commit 505e7ff15fb278dbe1f14ee7b61098091e4633d5
10 changes: 5 additions & 5 deletions packages/core/src/prompts/spinner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class SpinnerPrompt extends Prompt<undefined> {
#onCancel?: () => void;
#message: string = '';
#silentExit: boolean = false;
#exitCode: number | undefined = undefined;
#exitCode: number = 0;

constructor(opts: SpinnerOptions) {
super(opts);
Expand Down Expand Up @@ -64,7 +64,7 @@ export default class SpinnerPrompt extends Prompt<undefined> {

this.#reset();
this.#silentExit = silent === true;
this.#exitCode = exitCode;
this.#exitCode = exitCode ?? 0;

if (msg !== undefined) {
this.#message = msg;
Expand Down Expand Up @@ -116,7 +116,7 @@ export default class SpinnerPrompt extends Prompt<undefined> {

#reset(): void {
this.#isActive = false;
this.#exitCode = undefined;
this.#exitCode = 0;

if (this.#intervalId) {
clearInterval(this.#intervalId);
Expand All @@ -127,11 +127,11 @@ export default class SpinnerPrompt extends Prompt<undefined> {
}

#onInterval(): void {
this.render();

this.#frameIndex = this.#frameIndex + 1 < this.#frames.length ? this.#frameIndex + 1 : 0;
// indicator increase by 1 every 8 frames
this.#indicatorTimer = this.#indicatorTimer < 4 ? this.#indicatorTimer + 0.125 : 0;

this.render();
}

#onProcessError: () => void = () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/prompts/src/spinner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const spinner = ({
const hasGuide = opts.withGuide ?? settings.withGuide;

if (!this.isActive) {
if (this.silentExit) {
if (this.silentExit || this.state === 'initial') {
return '';
}
const step =
Expand Down