Detect and avoid 404 and 500 error pages (refined-github#893)

fregante · web-flow · commit fb590a1086f5 · 2017-12-20T17:01:30.000+08:00
diff --git a/source/content.js b/source/content.js
@@ -61,6 +61,9 @@ window.select = select;
 
 async function init() {
 	await safeElementReady('body');
+	if (pageDetect.is404() || pageDetect.is500()) {
+		return;
+	}
 	if (document.body.classList.contains('logged-out')) {
 		return;
 	}
diff --git a/source/libs/page-detect.js b/source/libs/page-detect.js
@@ -25,7 +25,9 @@ export const getOwnerAndRepo = () => {
 	return {ownerName, repoName};
 };
 
-export const is404 = () => document.title.startsWith('Page not found');
+export const is404 = () => document.title === 'Page not found · GitHub';
+
+export const is500 = () => document.title === 'Server Error · GitHub';
 
 export const isBlame = () => /^blame\//.test(getRepoPath());
 
diff --git a/test/page-detect.js b/test/page-detect.js
@@ -87,14 +87,31 @@ test('getOwnerAndRepo', t => {
 });
 
 test('is404', t => {
-	document.title = 'Page not found • GitHub';
+	document.title = 'Page not found · GitHub';
 	t.true(pageDetect.is404());
 
 	document.title = 'examples/404: Page not found examples';
 	t.false(pageDetect.is404());
 
 	document.title = 'Dashboard';
 	t.false(pageDetect.is404());
+
+	document.title = 'Page not found · Issue #266 · sintaxi/surge · GitHub';
+	t.false(pageDetect.is404());
+});
+
+test('is500', t => {
+	document.title = 'Server Error · GitHub';
+	t.true(pageDetect.is500());
+
+	document.title = 'examples/500: Server Error examples';
+	t.false(pageDetect.is500());
+
+	document.title = 'Dashboard';
+	t.false(pageDetect.is500());
+
+	document.title = 'Server Error · Issue #266 · sintaxi/surge · GitHub';
+	t.false(pageDetect.is500());
 });
 
 test('isBlame', urlMatcherMacro, pageDetect.isBlame, [

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,9 @@ window.select = select;`
`61`	`61`
`62`	`62`	`async function init() {`
`63`	`63`	`await safeElementReady('body');`
	`64`	`+ if (pageDetect.is404() \|\| pageDetect.is500()) {`
	`65`	`+ return;`
	`66`	`+ }`
`64`	`67`	`if (document.body.classList.contains('logged-out')) {`
`65`	`68`	`return;`
`66`	`69`	`}`