Add original width and height#90
Closed
doc-l2 wants to merge 4 commits intoblueimp:masterfrom
doc-l2:master
Closed
Add original width and height#90doc-l2 wants to merge 4 commits intoblueimp:masterfrom doc-l2:master
doc-l2 wants to merge 4 commits intoblueimp:masterfrom
doc-l2:master
Conversation
Owner
|
Thanks for your contribution, @L-Hendriks. |
Author
|
Hi Sebastian, Thanks for that! I agree the location is not be ideal, but I didn't want to change too much on the library. Have a nice weekend! |
Owner
|
Thanks @L-Hendriks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to have the original width and height of the image, and it seems to be impossible to get this information from the library without reloading the original image as an image. This is a big overhead, because you can also extract this information from within the lib.
I added two lines that append the width and height to the file object, is this the best place to put it?