Skip to content

Optimisation for thumbnail#88

Merged
blueimp merged 2 commits intoblueimp:masterfrom
bubbatls:patch-1
Mar 29, 2018
Merged

Optimisation for thumbnail#88
blueimp merged 2 commits intoblueimp:masterfrom
bubbatls:patch-1

Conversation

@bubbatls
Copy link
Copy Markdown
Contributor

@bubbatls bubbatls commented Mar 29, 2018

There is no need to rebuild a data uri.
We can use URL.createObjectURL and a Blob.
It is faster, and further use of the URL will be too.

@bubbatls
Optimisation for thumbnail
41b4b47 
There is no need to rebuild a data uri.
We can use URL.createObjectURL and a Blob.
It is faster, and further use of the URL will be too.
@blueimp
Copy link
Copy Markdown
Owner

blueimp commented Mar 29, 2018

Thanks @bubbatls
Could you update your pull request so it passes the linter rules?

@bubbatls
Copy link
Copy Markdown
Contributor Author

bubbatls commented Mar 29, 2018

Sorry, I've worked too fast and so... too dirty.
It's done

@blueimp
Copy link
Copy Markdown
Owner

blueimp commented Mar 29, 2018

Thanks again. :)

@blueimp blueimp merged commit 88de25f into blueimp:master Mar 29, 2018
@bubbatls
Copy link
Copy Markdown
Contributor Author

bubbatls commented Mar 29, 2018

maybe the code for building data-uri might be used in loadImage.createObjectURL when it is detected it does not work properly

@blueimp
Copy link
Copy Markdown
Owner

blueimp commented Mar 29, 2018

Could you clarify what you meany by "it does not work properly"?

@bubbatls
Copy link
Copy Markdown
Contributor Author

bubbatls commented Mar 29, 2018

The variable urlAPI might be undefined if it is not available or buggy (for opera 12 as I saw in comments)
And the data-uri might solve the issue, but maybe it is a bad idea to potentielly use it for something bigger than a thumbnail

@blueimp
Copy link
Copy Markdown
Owner

blueimp commented Mar 29, 2018

The EXIF code is only called in browsers that do support DataView.
Opera 12 is an edge case, but I don't think this browser is even supported anymore.
There's still Safari 6 (and potentially other browsers using webkitURL), but that is solved by using loadImage.createObjectURL.

@bubbatls
Copy link
Copy Markdown
Contributor Author

bubbatls commented Mar 30, 2018

Thanks for the explanation,
And thanks for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bubbatls @blueimp