You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It not actually broken, because I can't get canvas data (Tainted canvases may not be exported).
I append cropped image to body, and it transparent, but it should be black.
I think, bug in renderImageToCanvas calling with non-zero sourceX and sourceY in cycle, and image just moving out beyond the border of canvas.
If you agree, I can fix it, but I don't know how to check content of cropped image in test
To check the content of the image, you'll need to retrieve the canvas Image data.
You'll get back an ImageData object with a data property representing a one-dimensional array containing the data in the RGBA order, with integer values between 0 and 255 (included).
Just one note regarding your fix:
Instead of introducing another variable (cropped), please simply add the following two lines after the first loadImage.renderImageToCanvas call in the downsampling loop:
sourceX=0sourceY=0
After this change, please squash your commits into one (or two if you want to add the test separately).
Then I'll merge your changes gladly. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It not actually broken, because I can't get canvas data (Tainted canvases may not be exported).
I append cropped image to body, and it transparent, but it should be black.
I think, bug in renderImageToCanvas calling with non-zero
sourceXandsourceYin cycle, and image just moving out beyond the border of canvas.If you agree, I can fix it, but I don't know how to check content of cropped image in test