Reduce repeated ACP session context - #5423
Open
wesbillman wants to merge 2 commits into
Open
Conversation
Deliver legacy standing context once after a successful ACP prompt and track live-session event delivery so later thread and DM prompts send only deltas. Fence successful native steer acknowledgements by ACP session identity across task-result races. Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Distinguish history omitted because it was delivered earlier from a trigger-only fetch, and add regression coverage for channel delivery commit timing and stale in-flight steer acknowledgements. Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The pre-push hook passed on exact pushed head
6a768f1bc80fe63c686acf8d730f177fff8add3c:branch-skewdesktop-checkdesktop-typecheckdesktop-testrust-testsdesktop-tauri-checksFocused regression tests were also run while iterating:
channel_prompt_commits_delivery_state_only_after_acp_successin_flight_stale_native_steer_ack_cannot_update_replacement_sessionKnown limitations and follow-ups
A local Goose smoke timed out at
session/new. This diff does not change code that executes at or beforesession/new; its earliest affected runtime behavior is delivery-state insertion after session creation succeeds. The smoke failure is therefore bounded as environmental or pre-existing, but no successful live-provider turn was obtained. Scripted ACP wire/lifecycle tests carry the regression coverage.Durable process-restart/session resume remains out of scope for this slice of #5342. #5386 also remains separate pending upstream adapter support.