Skip to content

fix(relay): strip quotes from ETag before If-Match for Ceph RGW compat - #3003

Open
darox wants to merge 1 commit into
block:mainfrom
darox:fix/ceph-rgw-if-match-quoting
Open

fix(relay): strip quotes from ETag before If-Match for Ceph RGW compat#3003
darox wants to merge 1 commit into
block:mainfrom
darox:fix/ceph-rgw-if-match-quoting

Conversation

@darox

@darox darox commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Problem

Ceph RGW returns quoted ETags but rejects that form in If-Match. The relay forwards an ETag obtained from a read into the subsequent conditional write, causing CAS operations and the startup conformance probe to fail.

Fix

Remove surrounding double quotes only when setting If-Match. If-None-Match: * is unchanged.

Validation

  • Verified against Ceph RGW in a cluster.
  • cargo fmt --check
  • cargo clippy -p buzz-relay --lib -- -D warnings
  • cargo test -p buzz-relay --lib api::git::store::tests

Closes #3002

@darox
darox requested a review from a team as a code owner July 26, 2026 16:49
@darox darox mentioned this pull request Jul 26, 2026
Open
@darox
darox force-pushed the fix/ceph-rgw-if-match-quoting branch from cd6e536 to 96641c5 Compare July 26, 2026 16:55
@darox
darox marked this pull request as draft July 26, 2026 16:56
@darox
darox force-pushed the fix/ceph-rgw-if-match-quoting branch 2 times, most recently from c05319e to 5eac6ca Compare July 27, 2026 18:22
@darox
darox marked this pull request as ready for review July 27, 2026 18:22
dophsquare pushed a commit to darox/buzz that referenced this pull request Jul 28, 2026
Fizz (agent)
Merge branch 'main' into PR block#3003 to clear stale-base CI failure
4e90e36 
Co-authored-by: Phuoc (Phu) Do <91568955+dophsquare@users.noreply.github.com>
Signed-off-by: Phuoc (Phu) Do <91568955+dophsquare@users.noreply.github.com>

* origin/main: (84 commits)
  chore(ci): bump desktop smoke E2E timeout to 30 minutes (block#3409)
  release(chart): publish 0.1.7 (block#3393)
  feat(acp): steer claude-code and codex agents via _session/steering (block#3007)
  feat(desktop): apply WebKit rendering workarounds at startup on Linux (block#3271)
  fix(desktop): stabilize flaky DM expansion E2E ordering assertions (block#2004)
  docs(contributing): document the Linux system libraries just ci requires (block#3396)
  fix(desktop): paint community rail full height (block#3382)
  fix(acp): disable goose cron scheduler in managed agent children (block#3144)
  feat(desktop): add custom harness inline from agent dialogs (block#3252)
  chore(compose): remove stale typesense env vars (block#3332)
  feat(desktop): refine agent catalog sharing (block#2439)
  fix(desktop): keep drafts out of the Inbox All view (block#3217)
  docs: restructure DCO guidance into scannable subsection (block#3337)
  Unify mobile loading spinners (block#3314)
  fix(desktop): restore the inbox icon in the sidebar (block#3341)
  fix(desktop): gate codex-acp on a minimum supported version (block#3254)
  feat(cli): add users set-status command for NIP-38 profile status (block#3253)
  fix(composer): scope multiline block formatting (block#3246)
  feat(chart): add relay pod extension points (block#3322)
  Refine mobile attachment picking (block#3313)
  ...
@dophsquare

dophsquare commented Jul 29, 2026

Copy link
Copy Markdown

🤖 Review: changes requested — this should not merge as written.

crates/buzz-relay/src/api/git/store.rs:493 globally strips the quotes from every If-Match ETag. The store intentionally carries the response ETag opaquely from GET/PUT into the CAS write; making it unquoted changes behavior for every S3 backend, not only Ceph. Standard HTTP defines entity tags as quoted opaque strings and If-Match as entity tags (RFC 9110 §§8.8.3, 13.1.1: https://www.rfc-editor.org/rfc/rfc9110.html#section-13.1.1).

Action items:

  • Preserve the original quoted ETag for the default S3/MinIO path.
  • If Ceph needs a non-standard format, make it an explicit, opt-in backend compatibility policy rather than global normalization.
  • Add regression/integration coverage for the exact If-Match wire value on both standard S3 and Ceph-compatible paths.

@darox
darox force-pushed the fix/ceph-rgw-if-match-quoting branch 2 times, most recently from f7065ad to 277d5ff Compare August 3, 2026 09:01
@darox
fix(relay): make Ceph ETag normalization opt-in
69b3750 
Signed-off-by: darox <maderdario@gmail.com>
@darox
darox force-pushed the fix/ceph-rgw-if-match-quoting branch from 277d5ff to 69b3750 Compare August 3, 2026 09:26
@darox

darox commented Aug 9, 2026

Copy link
Copy Markdown
Author

🤖 Review: changes requested — this should not merge as written.

crates/buzz-relay/src/api/git/store.rs:493 globally strips the quotes from every If-Match ETag. The store intentionally carries the response ETag opaquely from GET/PUT into the CAS write; making it unquoted changes behavior for every S3 backend, not only Ceph. Standard HTTP defines entity tags as quoted opaque strings and If-Match as entity tags (RFC 9110 §§8.8.3, 13.1.1: https://www.rfc-editor.org/rfc/rfc9110.html#section-13.1.1).

Action items:

  • Preserve the original quoted ETag for the default S3/MinIO path.
  • If Ceph needs a non-standard format, make it an explicit, opt-in backend compatibility policy rather than global normalization.
  • Add regression/integration coverage for the exact If-Match wire value on both standard S3 and Ceph-compatible paths.

I fixed the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ceph RGW rejects quoted ETags in If-Match (412) — relay CAS / S3 conformance probe fails on Ceph-backed object storage

2 participants

@darox @dophsquare