Skip to content

Don't update project separately while starting test run#80

Merged
szprutamich merged 2 commits into
bitbar:masterfrom
ekreutz:start_test_run
May 7, 2018
Merged

Don't update project separately while starting test run#80
szprutamich merged 2 commits into
bitbar:masterfrom
ekreutz:start_test_run

Conversation

@ekreutz
Copy link
Copy Markdown

@ekreutz ekreutz commented May 3, 2018

Previously the api client would update the project before launching a test run using start_test_run(). This might cause race conditions when multiple users call the api client in close succession, and is unnecessary in any event since the /users/%s/projects/%s/runs call updates the project anyway.

Also, bumped version.

Users have requested this change.

@ekreutz ekreutz requested a review from srautiai May 3, 2018 22:53
@szprutamich szprutamich merged commit 82605cd into bitbar:master May 7, 2018
@srautiai
Copy link
Copy Markdown
Contributor

Please make pull request to devel branch. CI will take care of then of version bump and pushes is back to devel branch and then we can merge it to master = > PyPi ( @ekreutz @szprutamich )

@szprutamich
Copy link
Copy Markdown
Contributor

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants