Skip to content

Fix for file download on Linux and Mac #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spedepekka merged 2 commits into from
Jan 19, 2015
Merged

Fix for file download on Linux and Mac #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb2df3
Fix for file download issues on Linux and Macs
Jan 19, 2015
a096264
Fix for file download issues on Linux and Macs
Jan 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
0.1.8
* Fix file download for Linux and Mac machines.

0.1.7
* Add pillow to required dependencies
* Fix pillow Image import
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from setuptools import setup, find_packages
import sys, os

version = '0.1.7'
version = '0.1.8'

setup(name='testdroid',
version=version,
Expand Down
9 changes: 7 additions & 2 deletions testdroid/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from datetime import datetime

FORMAT = '%(message)s'
__version__ = '0.1.7'
__version__ = '0.1.8'
logging.basicConfig(format=FORMAT)
logger = logging.getLogger('testdroid')
logger.setLevel(logging.INFO)
Expand Down Expand Up @@ -172,7 +172,12 @@ def download(self, path=None, filename=None, payload={}, callback=None):
pos = 0
total = res.headers['content-length']

fd = os.open(filename, os.O_RDWR|os.O_CREAT|os.O_BINARY)
# Check if the system is Windows or not.
if os.name == 'nt':
fd = os.open(filename, os.O_RDWR|os.O_CREAT|os.O_BINARY)
else:
fd = os.open(filename, os.O_RDWR|os.O_CREAT)

for chunk in res.iter_content(self.download_buffer_size):
os.write(fd, chunk)
if callback:
Expand Down