Added retry feature for screenshots download and timeout handling for file download.#10
Merged
Merged
Conversation
added 2 commits
January 15, 2015 10:26
update fork test
hkivela
pushed a commit
that referenced
this pull request
Jan 15, 2015
Added retry feature for screenshots download and timeout handling for file download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry feature check if the file already exists and is valid png-image file and skips the download if check return true.
File download timeout (60s) is for better indication of download get stuck and failed. Most common reason for this is network errors.