Issue #13020: Fix a reference leak when allocating a structsequence object fails.

pitrou · pitrou · commit 9a7f8dfe721f · 2012-02-15T02:51:43.000+01:00
Patch by Suman Saha.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -9,6 +9,9 @@ What's New in Python 2.7.3?
 Core and Builtins
 -----------------
 
+- Issue #13020: Fix a reference leak when allocating a structsequence object
+  fails.  Patch by Suman Saha.
+
 - Issue #11235: Fix OverflowError when trying to import a source file whose
   modification time doesn't fit in a 32-bit timestamp.
 
diff --git a/Objects/structseq.c b/Objects/structseq.c
@@ -201,6 +201,7 @@ structseq_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 
     res = (PyStructSequence*) PyStructSequence_New(type);
     if (res == NULL) {
+        Py_DECREF(arg);
         return NULL;
     }
     for (i = 0; i < len; ++i) {

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ structseq_new(PyTypeObject type, PyObject args, PyObject *kwds)`
`201`	`201`
`202`	`202`	`res = (PyStructSequence*) PyStructSequence_New(type);`
`203`	`203`	`if (res == NULL) {`
	`204`	`+ Py_DECREF(arg);`
`204`	`205`	`return NULL;`
`205`	`206`	`}`
`206`	`207`	`for (i = 0; i < len; ++i) {`