Issue #13015: Fix a possible reference leak in defaultdict.__repr__.

pitrou · pitrou · commit 2e19e8ed5f02 · 2012-02-15T02:42:46.000+01:00
Patch by Suman Saha.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -90,6 +90,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #13015: Fix a possible reference leak in defaultdict.__repr__.
+  Patch by Suman Saha.
+
 - Issue #13979: A bug in ctypes.util.find_library that caused
   the wrong library name to be returned has been fixed.
 
diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
@@ -1475,8 +1475,10 @@ defdict_repr(defdictobject *dd)
     {
         int status = Py_ReprEnter(dd->default_factory);
         if (status != 0) {
-            if (status < 0)
+            if (status < 0) {
+                Py_DECREF(baserepr);
                 return NULL;
+            }
             defrepr = PyString_FromString("...");
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -1475,8 +1475,10 @@ defdict_repr(defdictobject *dd)`
`1475`	`1475`	`{`
`1476`	`1476`	`int status = Py_ReprEnter(dd->default_factory);`
`1477`	`1477`	`if (status != 0) {`
`1478`		`- if (status < 0)`
	`1478`	`+ if (status < 0) {`
	`1479`	`+ Py_DECREF(baserepr);`
`1479`	`1480`	`return NULL;`
	`1481`	`+ }`
`1480`	`1482`	`defrepr = PyString_FromString("...");`
`1481`	`1483`	`}`
`1482`	`1484`	`else`