Merge bugfix4.2 branch - #819
Merged
Merged
Conversation
…usually indicative of misformated lines. Added line length checks within the LINK and CONECT parsing blocks to allow for short lines to be parsed.
Bugfix in hmmer web service
…coding region on the forward strand
…e position on mRNA for the genes leaving on the forward strand
…for the genes leaving on the forward strand
…eceding the coding region
Updating to latest RCSB URLs for 4.2.x
Cherry-pick the c5fa135 commit
Fix rcsb/symmetry#92: NullPointerException
log slow downloads upon start
The main change hasn't been implemented, so we want tests to fail. However, the tests exposed some NPE and IO exceptions. These are now fixed, so the tests fail in the expected manner. - Use ATP ligand, which is not covered by the ReducedChemCompProvider - Use the ReducedChemCompProvider as a fallback consistently, preventing null chemComp - Defensive parsing in SimpleMMcifConsumer - Robust test, doesn't require internet!
Files less than 40 bytes are deleted to allow for gzip headers. This addresses biojava#703
This is necessary when changing the cache path.
See comments on biojava#774
Use GlobalsHelper.pushState()/restoreState() before and after tests to ensure that state isn't carried between tests. This is applied to the AtomCacheTest to fix test regressions while simplifying the code.
Maven runs tests with a clean environment, so we can't restore PDB_DIR
4LNC was updated to remove the X-Ray experimental method. This switches the test to 6F2Q, which uses both Neutron & Xray.
Parsing such a file again throws a NumberFormatException. Further work/discussion of this issue is on biojava#775, but it was blocking the merging of biojava#774.
Fix biojava#703: Recover from empty structure files in PDB_CACHE_DIR
Uniprot now redirects to https. This fixes the URL, as well as adds code to do the redirect
Member
Author
|
This still has some test failures. |
- New feature to re-download too-short files broke some negative tests - Switched to authId for some chains
Member
Author
|
OK, good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a while since merging the bugfix4.2 branch into master, and some changes have accumulated.
biojava-genome/src/main/java/org/biojava/nbio/genome/util/ChromosomeMappingTools.javaandbiojava-genome/src/test/java/org/biojava/nbio/genome/TestGenomeMapping.javahad large conflicts and I mostly just kept the 5.x version. Hopefully no important changes get lost.