Skip to content

Fix #741 - #744

Merged
josemduarte merged 1 commit into
biojava:masterfrom
lafita:mcbug
Mar 9, 2018
Merged

Fix #741#744
josemduarte merged 1 commit into
biojava:masterfrom
lafita:mcbug

Conversation

@lafita

@lafita lafita commented Mar 9, 2018

Copy link
Copy Markdown
Member

I added the selection of the structure from the pool of free residues (not aligned).

@lafita lafita added this to the BioJava 5.0.0 milestone Mar 9, 2018
@lafita
lafita requested a review from josemduarte March 9, 2018 15:37

@josemduarte josemduarte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

I found this issue by simply looking at warnings in the IDE. A note for everyone: it is good practice to get rid of all harmless warnings (e.g. unused variables or imports) so that the important ones like this become more prominent and can be caught.

@josemduarte

Copy link
Copy Markdown
Contributor

I've tested locally and all is fine, I'll merge

@josemduarte
josemduarte merged commit fe8671b into biojava:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants