Skip to content

Fixing issue with Calc.transform(Chain,Matrix4d) #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josemduarte merged 4 commits into from
Dec 12, 2017
Merged

Fixing issue with Calc.transform(Chain,Matrix4d) #716

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc9011a
Fix and unit test for #715
josemduarte Dec 7, 2017
3a1ad26
Fixing also Calc.transform(Structure,Matrix4d)
josemduarte Dec 8, 2017
8a7e22c
Fixes for translate functions, similar to #715
josemduarte Dec 8, 2017
e0c031b
Recursive transform for group
josemduarte Dec 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Recursive transform for group
  • Loading branch information
@josemduarte
josemduarte committed Dec 9, 2017
commit e0c031b62420d86c9a3657eab440326852660ec2
8 changes: 2 additions & 6 deletions biojava-structure/src/main/java/org/biojava/nbio/structure/Calc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,9 +542,7 @@ public static final void transform(Group group, Matrix4d m) {
transform(atom, m);
}
for (Group altG : group.getAltLocs()) {
for (Atom atom : altG.getAtoms()) {
transform(atom, m);
}
transform(altG, m);
}
}

Expand Down Expand Up @@ -606,9 +604,7 @@ public static final void translate(Group group, Vector3d v) {
translate(atom, v);
}
for (Group altG : group.getAltLocs()) {
for (Atom atom : altG.getAtoms()) {
translate(atom, v);
}
translate(altG, v);
}
}

Expand Down