Implemented reading of mmCIF 5.0 changes in the _pdbx_database_status#684
Merged
Conversation
category and the new dbx_audit_revision_history. The deposition, release, and modification dates are read from these categories if available. This commit resolved #678. Note, code that sets and gets the release date is commented out until the PdbHeader supports release date.
lafita
approved these changes
Jul 6, 2017
Member
lafita
left a comment
There was a problem hiding this comment.
Thanks Peter, looks great to me. I will uncomment the release date section when merging and make sure the test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
category and the new dbx_audit_revision_history.
The deposition, release, and modification dates are read from these
categories if available.
This commit resolved #678. Note, code that sets and gets the release
date is commented out until the PdbHeader supports release date.