Fix Quaternary symmetry symmetry detection bug#634
Merged
sbliven merged 2 commits intobiojava:bugfixes-4.2from Feb 15, 2017
Merged
Fix Quaternary symmetry symmetry detection bug#634sbliven merged 2 commits intobiojava:bugfixes-4.2from
sbliven merged 2 commits intobiojava:bugfixes-4.2from
Conversation
Don't allow subunits to be aligned to themselves (except for the identity alignment).
In special cases it was possible to have pairs of axes that pass our quality thresholds but form invalid symmetry groups. Now alignments that superimpose a subunit onto itself are forbidden, which should restrict it to the chiral groups. Also add numerous notes and documentation.
Contributor
|
Nice thanks! On time for the next bugfix release. I will try to do the release before next week. I'll also merge this one onto master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In special cases it was possible to have pairs of axes that
pass our quality thresholds but form invalid symmetry groups.
Now alignments that superimpose a subunit onto itself are forbidden,
which should restrict it to the chiral groups.
Also add numerous notes and documentation.