Skip to content

pmd:InefficientStringBuffering - Inefficient String Buffering - #519

Merged
josemduarte merged 1 commit into
biojava:masterfrom
DevFactory:release--inefficient-string-buffering-fix-1
Jul 4, 2016
Merged

pmd:InefficientStringBuffering - Inefficient String Buffering#519
josemduarte merged 1 commit into
biojava:masterfrom
DevFactory:release--inefficient-string-buffering-fix-1

Conversation

@m-ezzat

@m-ezzat m-ezzat commented Jun 22, 2016

Copy link
Copy Markdown
Contributor

This pull request is focused on resolving occurrences of Sonar rule pmd:InefficientStringBuffering - Inefficient String Buffering

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=pmd:InefficientStringBuffering

Please let me know if you have any questions.

M-Ezzat

@m-ezzat

m-ezzat commented Jun 30, 2016

Copy link
Copy Markdown
Contributor Author

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

@josemduarte

Copy link
Copy Markdown
Contributor

There are some conflicts now after the latest merges... Could you try to merge master onto your branch and solve the conflicts? After that we can merge this one too.

@m-ezzat

m-ezzat commented Jul 1, 2016

Copy link
Copy Markdown
Contributor Author

Yes I can, it's rebased from the master branch.

@josemduarte
josemduarte merged commit 35deefe into biojava:master Jul 4, 2016
@josemduarte

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants