Fix for bug #327 StructureTools#getGroupsWithingShell(Structure, Group,double,boolean) method should return Set<Group>#328
Merged
Conversation
Updating local fork
a List as per bug report biojava#327 StructureTools#getGroupsWithingShell(Structure, Group,double,boolean) method should return Set<Group>
josemduarte
added a commit
that referenced
this pull request
Sep 18, 2015
Fix for bug #327 StructureTools#getGroupsWithingShell(Structure, Group,double,boolean) method should return Set<Group>
sroughley
added a commit
to sroughley/biojava
that referenced
this pull request
Sep 22, 2015
Merge pull request biojava#328 from sroughley/master
kamildoleglo
pushed a commit
to kamildoleglo/biojava
that referenced
this pull request
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After checking, there appear to be no calls to this method within Biojava, and therefore the method signature has been changed to Set, and the implementation returns a LinkedHashSet()