添加maven warpper以及依赖更新检查脚本#438
Closed
unlimitedsola wants to merge 3 commits intobinarywang:masterfrom
unlimitedsola:master
Closed
添加maven warpper以及依赖更新检查脚本#438unlimitedsola wants to merge 3 commits intobinarywang:masterfrom unlimitedsola:master
unlimitedsola wants to merge 3 commits intobinarywang:masterfrom
unlimitedsola:master
Conversation
Signed-off-by: Sola <dev@sola.love>
Signed-off-by: Sola <dev@sola.love>
Owner
|
谢谢您贡献的代码,不过请提交到develop分支,详情可以阅读下贡献指南,再次感谢 |
Owner
|
另外能否简单解释下这个玩意是做什么的? |
Owner
|
另外规定PR到develop分支,也是为了方便后续发版本时在合并master分支时便于整理更新内容,希望够理解配合 |
Author
|
和gradle wrapper一样,可以在用户没有安装maven的情况下通过mvnw脚本构建 |
Author
|
依赖更新检查可以检查仓库依赖的更新状况 |
Owner
|
那你早说就好了,这个确实也对主代码没影响,只是相当于多了个监测功能 |
Author
|
所以还是需要提交到develop分支吗? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR到master的原因是这两个commit没有对现有代码做出改动