Skip to content

对帐单下载bug #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binarywang merged 1 commit into from
Jul 21, 2017
Merged

对帐单下载bug #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions ...-pay/src/main/java/com/github/binarywang/wxpay/service/impl/WxPayServiceAbstractImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,33 +359,34 @@ private WxPayBillResult billInformationDeal(String responseContent) {
for (int i = 0; i < j; i++) {
WxPayBillBaseResult wxPayBillBaseResult = new WxPayBillBaseResult();

wxPayBillBaseResult.setTradeTime(tempStr[k]);
wxPayBillBaseResult.setAppId(tempStr[k + 1]);
wxPayBillBaseResult.setMchId(tempStr[k + 2]);
wxPayBillBaseResult.setSubMchId(tempStr[k + 3]);
wxPayBillBaseResult.setDeviceInfo(tempStr[k + 4]);
wxPayBillBaseResult.setTransationId(tempStr[k + 5]);
wxPayBillBaseResult.setOutTradeNo(tempStr[k + 6]);
wxPayBillBaseResult.setOpenId(tempStr[k + 7]);
wxPayBillBaseResult.setTradeType(tempStr[k + 8]);
wxPayBillBaseResult.setTradeState(tempStr[k + 9]);
wxPayBillBaseResult.setBankType(tempStr[k + 10]);
wxPayBillBaseResult.setFeeType(tempStr[k + 11]);
wxPayBillBaseResult.setTotalFee(tempStr[k + 12]);
wxPayBillBaseResult.setCouponFee(tempStr[k + 13]);
wxPayBillBaseResult.setRefundId(tempStr[k + 14]);
wxPayBillBaseResult.setOutRefundNo(tempStr[k + 15]);
wxPayBillBaseResult.setSettlementRefundFee(tempStr[k + 16]);
wxPayBillBaseResult.setCouponRefundFee(tempStr[k + 17]);
wxPayBillBaseResult.setRefundChannel(tempStr[k + 18]);
wxPayBillBaseResult.setRefundState(tempStr[k + 19]);
wxPayBillBaseResult.setBody(tempStr[k + 20]);
wxPayBillBaseResult.setAttach(tempStr[k + 21]);
wxPayBillBaseResult.setPoundage(tempStr[k + 22]);
wxPayBillBaseResult.setPoundageRate(tempStr[k + 23]);
wxPayBillBaseResult.setTradeTime(tempStr[k].trim());
Copy link
Copy Markdown
Owner

@binarywang binarywang Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得trim()这个方法不保险，不如使用StringUtils.trimToNull或者trimToEmpty

Copy link
Copy Markdown
Author

@lwxian lwxian Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你是担心空指针吗？
354行：String newStr = listStr.replaceAll(",", " "); // 去空格

这段代码在每个值后面加了个空格，应该是不会有空指针这种情况

Copy link
Copy Markdown
Author

@lwxian lwxian Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过你的担心是对的，按你的改也没有问题！

wxPayBillBaseResult.setAppId(tempStr[k + 1].trim());
wxPayBillBaseResult.setMchId(tempStr[k + 2].trim());
wxPayBillBaseResult.setSubMchId(tempStr[k + 3].trim());
wxPayBillBaseResult.setDeviceInfo(tempStr[k + 4].trim());
wxPayBillBaseResult.setTransationId(tempStr[k + 5].trim());
wxPayBillBaseResult.setOutTradeNo(tempStr[k + 6].trim());
wxPayBillBaseResult.setOpenId(tempStr[k + 7].trim());
wxPayBillBaseResult.setTradeType(tempStr[k + 8].trim());
wxPayBillBaseResult.setTradeState(tempStr[k + 9].trim());
wxPayBillBaseResult.setBankType(tempStr[k + 10].trim());
wxPayBillBaseResult.setFeeType(tempStr[k + 11].trim());
wxPayBillBaseResult.setTotalFee(tempStr[k + 12].trim());
wxPayBillBaseResult.setCouponFee(tempStr[k + 13].trim());
wxPayBillBaseResult.setRefundId(tempStr[k + 14].trim());
wxPayBillBaseResult.setOutRefundNo(tempStr[k + 15].trim());
wxPayBillBaseResult.setSettlementRefundFee(tempStr[k + 16].trim());
wxPayBillBaseResult.setCouponRefundFee(tempStr[k + 17].trim());
wxPayBillBaseResult.setRefundChannel(tempStr[k + 18].trim());
wxPayBillBaseResult.setRefundState(tempStr[k + 19].trim());
wxPayBillBaseResult.setBody(tempStr[k + 20].trim());
wxPayBillBaseResult.setAttach(tempStr[k + 21].trim());
wxPayBillBaseResult.setPoundage(tempStr[k + 22].trim());
wxPayBillBaseResult.setPoundageRate(tempStr[k + 23].trim());
wxPayBillBaseResultLst.add(wxPayBillBaseResult);
k += t.length;
}
wxPayBillResult.setWxPayBillBaseResultLst(wxPayBillBaseResultLst);
/*
* 总交易单数,总交易额,总退款金额,总代金券或立减优惠退款金额,手续费总金额 `2,`0.02,`0.0,`0.0,`0
*/
Expand Down