Extract timestamp validation into a class method

Koronen · Koronen · commit bc75015c06b7 · 2013-09-23T16:19:08.000+02:00
diff --git a/app/repositories/feed_repository.rb b/app/repositories/feed_repository.rb
@@ -8,11 +8,7 @@ def self.fetch_by_ids(ids)
   end
 
   def self.update_last_fetched(feed, timestamp)
-    is_invalid_timestamp = timestamp.nil? ||
-      timestamp.year < MIN_YEAR ||
-      (feed.last_fetched && timestamp <= feed.last_fetched)
-
-    unless is_invalid_timestamp
+    unless self.is_invalid_timestamp(timestamp, feed.last_fetched)
       feed.last_fetched = timestamp
       feed.save
     end
@@ -30,5 +26,12 @@ def self.set_status(status, feed)
   def self.list
     Feed.order('lower(name)')
   end
-end
 
+  private
+
+  def self.is_invalid_timestamp(new_timestamp, current_timestamp)
+    new_timestamp.nil? ||
+      new_timestamp.year < MIN_YEAR ||
+      (current_timestamp && new_timestamp <= current_timestamp)
+  end
+end
