Don't update last_fetched when given an older timestamp

Koronen · Koronen · commit 2b8d73678aff · 2013-09-23T16:13:26.000+02:00
diff --git a/app/repositories/feed_repository.rb b/app/repositories/feed_repository.rb
@@ -8,10 +8,14 @@ def self.fetch_by_ids(ids)
   end
 
   def self.update_last_fetched(feed, timestamp)
-    is_invalid_timestamp = timestamp.nil? || timestamp.year < MIN_YEAR
-
-    feed.last_fetched = timestamp unless is_invalid_timestamp
-    feed.save
+    is_invalid_timestamp = timestamp.nil? ||
+      timestamp.year < MIN_YEAR ||
+      (feed.last_fetched && timestamp <= feed.last_fetched)
+
+    unless is_invalid_timestamp
+      feed.last_fetched = timestamp
+      feed.save
+    end
   end
 
   def self.delete(feed_id)
diff --git a/spec/repositories/feed_repository_spec.rb b/spec/repositories/feed_repository_spec.rb
@@ -32,5 +32,14 @@
 
       feed.last_fetched.should eq timestamp
     end
+
+    it "doesn't update if timestamp is older than the current value" do
+      feed = Feed.new(last_fetched: timestamp)
+      one_week_ago = timestamp - 1.week
+
+      result = FeedRepository.update_last_fetched(feed, one_week_ago)
+
+      feed.last_fetched.should eq timestamp
+    end
   end
 end
