Merge pull request chef-boneyard#525 from chef-cookbooks/modes

tas50 · web-flow · commit af3011631ec3 · 2017-10-16T09:02:24.000-07:00
Use full modes for everything
diff --git a/libraries/helpers.rb b/libraries/helpers.rb
@@ -55,7 +55,7 @@ def create_chef_directories
           rescue Chef::Exceptions::ResourceNotFound
             directory node['chef_client'][dir] do
               recursive true
-              mode '755' if dir == 'log_dir'
+              mode '0755' if dir == 'log_dir'
               owner d_owner
               group node['root_group']
             end
diff --git a/recipes/bsd_service.rb b/recipes/bsd_service.rb
@@ -26,7 +26,7 @@ class ::Chef::Recipe
     owner 'root'
     group 'wheel'
     variables client_bin: client_bin
-    mode '755'
+    mode '0755'
   end
 
   # Remove wrong rc.d script created by an older version of cookbook
@@ -35,7 +35,7 @@ class ::Chef::Recipe
   end
 
   template '/etc/rc.conf.d/chef' do
-    mode '644'
+    mode '0644'
     notifies :start, 'service[chef-client]', :delayed
   end
 
diff --git a/recipes/config.rb b/recipes/config.rb
@@ -79,7 +79,7 @@ class ::Chef::Recipe
   source 'client.rb.erb'
   owner d_owner
   group node['root_group']
-  mode '644'
+  mode '0644'
   variables(
     chef_config: node['chef_client']['config'],
     chef_requires: chef_requires,
@@ -99,7 +99,7 @@ class ::Chef::Recipe
   recursive true
   owner d_owner
   group node['root_group']
-  mode '755'
+  mode '0755'
 end
 
 ruby_block 'reload_client_config' do
diff --git a/recipes/cron.rb b/recipes/cron.rb
@@ -44,13 +44,13 @@ class ::Chef::Recipe
 if node['os'] == 'linux'
   template '/etc/init.d/chef-client' do
     source "#{dist_dir}/init.d/chef-client.erb"
-    mode '755'
+    mode '0755'
     variables(client_bin: client_bin)
   end
 
   template "/etc/#{conf_dir}/chef-client" do
     source "#{dist_dir}/#{conf_dir}/chef-client.erb"
-    mode '644'
+    mode '0644'
   end
 
   service 'chef-client' do
@@ -74,7 +74,7 @@ class ::Chef::Recipe
     owner 'root'
     group 'wheel'
     variables client_bin: client_bin
-    mode '755'
+    mode '0755'
   end
 
   file '/etc/rc.conf.d/chef' do
diff --git a/recipes/launchd_service.rb b/recipes/launchd_service.rb
@@ -18,7 +18,7 @@ class ::Chef::Recipe
 
 template '/Library/LaunchDaemons/com.chef.chef-client.plist' do
   source 'com.chef.chef-client.plist.erb'
-  mode '644'
+  mode '0644'
   variables(
     launchd_mode: node['chef_client']['launchd_mode'],
     client_bin: client_bin
diff --git a/recipes/systemd_service.rb b/recipes/systemd_service.rb
@@ -27,7 +27,7 @@ class ::Chef::Recipe
 
 env_file = template "/etc/#{conf_dir}/#{env_file}" do
   source "#{dist_dir}/#{conf_dir}/chef-client.erb"
-  mode '644'
+  mode '0644'
   notifies :restart, 'service[chef-client]', :delayed unless timer
 end
 
